individal admin tweaks for wallet #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdinicola
force-pushed
the
admin-tweaks
branch
from
d7c7a9c
to
30dad25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4386 +/- ##
===========================================
- Coverage 77.95% 77.67% -0.28%
===========================================
Files 941 942 +1
Lines 44456 44455 -1
===========================================
- Hits 34656 34532 -124
- Misses 9800 9923 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
domdinicola
changed the title
domdinicola
force-pushed
the
admin-tweaks
branch
from
30dad25
to
4cf7619
Compare
domdinicola
requested review from
johniak,
pavlo-mk,
MarekBiczysko and
pkujawa
MarekBiczysko
requested changes
Oct 30, 2024
| class IndividualDeliveryMechanismDataInline(admin.TabularInline): | ||
| model = DeliveryMechanismData | ||
| extra = 0 | ||
| fields = ("delivery_mechanism_choice", "delivery_mechanism", "data", "is_valid") |
There was a problem hiding this comment.
delivery_mechanism_choice field is legacy and will be dropped, no need to include it here
| model = DeliveryMechanismData | ||
| extra = 0 | ||
| fields = ("delivery_mechanism_choice", "delivery_mechanism", "data", "is_valid") | ||
| readonly_fields = ("delivery_mechanism_choice", "delivery_mechanism", "data", "is_valid") |
There was a problem hiding this comment.
delivery_mechanism_choice field is legacy and will be dropped, no need to include it here
MarekBiczysko
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.